Skip to content

CI: Fix Android Windows Signing#12912

Merged
HTRamsey merged 1 commit intomavlink:masterfrom
HTRamsey:dev-windows-android-signing
May 28, 2025
Merged

CI: Fix Android Windows Signing#12912
HTRamsey merged 1 commit intomavlink:masterfrom
HTRamsey:dev-windows-android-signing

Conversation

@HTRamsey
Copy link
Collaborator

Attempting to fix windows reading keystore

@HTRamsey HTRamsey force-pushed the dev-windows-android-signing branch 3 times, most recently from 7c639ac to bee4035 Compare May 26, 2025 02:36
@HTRamsey HTRamsey force-pushed the dev-windows-android-signing branch from bee4035 to 87e048e Compare May 26, 2025 03:05
@HTRamsey HTRamsey requested a review from DonLakeFlyer May 27, 2025 18:23
@HTRamsey
Copy link
Collaborator Author

If this doesn't work we'll just temporarily disable it again since it's mainly meant as just a build check, and signing works locally.

@HTRamsey HTRamsey marked this pull request as ready for review May 27, 2025 18:28
@DonLakeFlyer
Copy link
Collaborator

So that fixed it? The binary thing?

@HTRamsey
Copy link
Collaborator Author

When looking it up I found a bunch of posts about Java version but I know that's correct, and one about line endings when windows is parsing the keystore file, so I'm hoping that's it.

@HTRamsey HTRamsey merged commit cd4444f into mavlink:master May 28, 2025
7 checks passed
@HTRamsey HTRamsey deleted the dev-windows-android-signing branch May 28, 2025 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants