CI: Fix Android Windows Signing#12912
Merged
HTRamsey merged 1 commit intomavlink:masterfrom May 28, 2025
Merged
Conversation
7c639ac to
bee4035
Compare
bee4035 to
87e048e
Compare
Collaborator
Author
|
If this doesn't work we'll just temporarily disable it again since it's mainly meant as just a build check, and signing works locally. |
Collaborator
|
So that fixed it? The binary thing? |
Collaborator
Author
|
When looking it up I found a bunch of posts about Java version but I know that's correct, and one about line endings when windows is parsing the keystore file, so I'm hoping that's it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempting to fix windows reading keystore