Merged
Conversation
Collaborator
|
Hmm, never seen this code before. I assume if you tested then it should be all good now. |
Collaborator
Author
|
Yup I tested. It's only a thing with ardupilot but shows you on the vehicle page which sensors are on the board. Kinda cool, I was thinking about adding something like it for PX4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
busTypeis a string, so the existing logic has never worked. This bug resulted in the compass being reported asWith the fixed logic it is now
The DroneCAN MagneticFieldStrength2 message only has a
uint8 idwhich is used for sensor instance reporting. There is no mechanism to report device type of the magnetometer sensor (eg ii2smdc, hmc5883, etc)