QML: Fix Accidental Hiding of Main Window#12860
QML: Fix Accidental Hiding of Main Window#12860HTRamsey wants to merge 1 commit intomavlink:masterfrom
Conversation
|
Thank you! This was my bad. |
|
This one was tough because it wasn't what I was looking for at all. I'm not sure I actually understand how a Connections object changes the namespace to the mainwindow |
AFAIK it's a child of its target. |
|
Might be a problem here as well, although I guess in this case it would just make the QML engine complain about the multiVehicleManager not having a property called "visible". Not 100% sure. Coming to think of it, that entire Connections block is probably redundant because gotoLocationItem already becomes invisible under that same condition and fwdFlightGotoMapCircle has its visibility tied to it. |
|
Hah, I was just hitting this debugging the usb pull crash. Wondering what the hell was going on! |
|
I deal with this in my usb disconnect fix |
|
For me, removing this: Isn't fixing the main window hide problem. No idea why... |
|
@DonLakeFlyer that one hides the flyview or something, the one with gotoLocationItem.hide() was hiding the whole window |
|
@rubenp02 Not quite sure about whether both of the Connections blocks for null activeVehicle were added by you. If so, was there a reason why? Do you find a case which didn't work. There is already other code which tracks the _activeVehicle going away which works fine. I removed both blocks and tested that the goto location item goes away correctly. Did you see something different? |
Fix #12858