Conversation
This adds the logic we have in place for other camera requets already. We try to request it both using the old specific command as well as using the newer general MAV_CMD_REQUEST_MESSAGE command.
We have to try both commands, the deprecated specific one and the new generic one. We do this by calling the function twice. Also, we need to wait just a little bit in the "Basic" case because otherwise we seem to conflict with another MAV_CMD_REQUEST_MESSAGE and trigger a duplicate command request in which case the command is never sent out. This will need proper fixing in the underlying MAV_CMD_REQUEST_MESSAGE logic but for now this improves discovery of a camera, at least in my case.
We need to call factChanged initially, otherwise the ranges and exclusions are not taken into account when first displaying the camera settings UI. (They are taken into account on subsequent updates.)
HTRamsey
approved these changes
Apr 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have been testing against a camera manager that I'm bringing up and ran into little issues requesting the messages and displaying the settings correctly initially. See commits for review and more detail.