Update Manual Control to support 6dof#2005
Merged
vooon merged 2 commits intomavlink:ros2from Oct 23, 2024
Merged
Conversation
vooon
approved these changes
Oct 21, 2024
Member
vooon
left a comment
There was a problem hiding this comment.
Overall looks good. Except I'm not sure about aux, maybe better aux[6]. But at the same time command params are after mavlink...
Contributor
Author
Let me know if you for certain want me to make it |
Member
|
I don't have strong preference on array, so it's okay to stick to mavlink definition. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated message definition found here.
Tested on my pixhawk running ArduSub by reading /mavros/rc/out.