Resolve build error when linking yaml-cpp#1994
Merged
vooon merged 3 commits intomavlink:ros2from Sep 22, 2024
evan-palmer:bug-yaml-cpp-humble-build
Merged
Resolve build error when linking yaml-cpp#1994vooon merged 3 commits intomavlink:ros2from evan-palmer:bug-yaml-cpp-humble-build
vooon merged 3 commits intomavlink:ros2from
evan-palmer:bug-yaml-cpp-humble-build
Conversation
Contributor
Author
|
Hmm looking into the issue with the CI now. EDIT: Looks like I made an error when rebasing the first time. Should be fixed now. Going to let the CI run once before I mark the PR as ready for review. |
Contributor
Author
|
Looks like all errors are from previous tests - not the builds |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the pre-Jazzy build error introduced in #1988, where
yaml-cppcannot be found. I've done some testing to verify that things build and run as expected using ROS 2 Humble, Iron, Jazzy, and Rolling.