Fix dropped messages by libmav_receiver.cpp#2722
Merged
julianoes merged 1 commit intomavlink:mainfrom Dec 1, 2025
Merged
Conversation
Enable parsing multiple messages from one datagram
|
Contributor
Author
|
Based on issue description probably fixes #2685 |
julianoes
approved these changes
Dec 1, 2025
Collaborator
julianoes
left a comment
There was a problem hiding this comment.
Amazing, thanks! This was clearly wrong!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR to receive all MAVLink messages when using
libmav_receiver.cppBackground: we noticed significant amount of messages being dropped by MAVSDK server. This was verified by comparing received message count between
pymavlinkandmavsdk_server, while using discretely sent msg type (CAMERA_IMAGE_CAPTURED) for easier counting. On pymavlink, all messages came through. MAVSDK dropped roughly a third of messages. Missing messages was double checked with other streams.In
mavlink_receiver.cpp, there is a comment:// Note that one datagram can contain multiple mavlink messages.But
libmav_receiver.cppalways setdatagramtonullptrafter parsing one message - essentially discarding any remaining messages in thedatagram.Changes tested with PX4-based flightcontroller connected over serial to aarch64/Ubuntu 22.04-based machine running mavsdk_server binary. No message drops observed with patched code.