Conversation
It turns out jsoncpp uses isUInt for numbers below 2^32 and isUInt64 for numbers above 2^32.
1f04eb2 to
6c0a548
Compare
Just in case, to make sure big numbers get handled correctly.
Turns out libmavlike does all the casting already.
|
Contributor
|
Nice cleanup. Did you test with a small number in a uin64 for instance? That's how I encountered the issue. |
Collaborator
Author
I'm pretty sure a small number should still work, I just tested it using a system_test and it seemed to pass. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It turns out jsoncpp uses isUInt for numbers below 2^32 and isUInt64 for numbers above 2^32.
Fixes #2679.