Skip to content

Add some Arduplane flight modes and VTOL support#2676

Merged
julianoes merged 2 commits intomavlink:mainfrom
Luc-Meunier:arduplane-flight-modes
Oct 27, 2025
Merged

Add some Arduplane flight modes and VTOL support#2676
julianoes merged 2 commits intomavlink:mainfrom
Luc-Meunier:arduplane-flight-modes

Conversation

@Luc-Meunier
Copy link
Copy Markdown
Contributor

@Luc-Meunier Luc-Meunier commented Oct 5, 2025

No description provided.

@Luc-Meunier Luc-Meunier mentioned this pull request Oct 5, 2025
Closed
@JonasVautherin
Copy link
Copy Markdown
Collaborator

JonasVautherin commented Oct 5, 2025 •
edited
Loading

CI fails with:

/work/src/mavsdk/plugins/events/events_impl.cpp: In member function ‘std::string mavsdk::EventsImpl::mode_name_from_custom_mode(uint32_t) const’:
/work/src/mavsdk/plugins/events/events_impl.cpp:356:12: error: enumeration value ‘FBWB’ not handled in switch [-Werror=switch]
  356 |     switch (to_flight_mode_from_custom_mode(
      |            ^
cc1plus: all warnings being treated as errors

Is this enough to add support for those flight modes? I think it's great that you're contributing more support for ArduPlane, thanks for that!

@Luc-Meunier Luc-Meunier force-pushed the arduplane-flight-modes branch from c50296f to a768ce9 Compare October 5, 2025 19:48
julianoes
julianoes approved these changes Oct 6, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@julianoes julianoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that's ok, thanks.

@Luc-Meunier
Copy link
Copy Markdown
Contributor Author

Luc-Meunier commented Oct 18, 2025

Hi, can you help me with the Ubuntu 24.04 (ThreadSanitizer) failure please?
I don't understand the reason...

@JonasVautherin
Copy link
Copy Markdown
Collaborator

JonasVautherin commented Oct 19, 2025

@Luc-Meunier: wasn't it fixed in a separate PR? I think you can try rebasing on main and it should now work 👍

@julianoes
Copy link
Copy Markdown
Collaborator

julianoes commented Oct 20, 2025

Yes, please rebase on main and force push.

@Luc-Meunier Luc-Meunier force-pushed the arduplane-flight-modes branch from 58279d8 to bcdc2b0 Compare October 26, 2025 22:09
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Oct 26, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@julianoes julianoes merged commit cf8aff8 into mavlink:main Oct 27, 2025
53 of 54 checks passed
@PavelGuzenfeld PavelGuzenfeld mentioned this pull request Mar 30, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@julianoes julianoes julianoes approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Luc-Meunier @JonasVautherin @julianoes