dependencies: libevents should be built with the superbuild#2673
Merged
dependencies: libevents should be built with the superbuild#2673
Conversation
Collaborator
|
Looks like we need to fix macOS CI. |
julianoes
previously approved these changes
Oct 1, 2025
Collaborator
julianoes
left a comment
There was a problem hiding this comment.
I think that's right!
b735297 to
451c7a4
Compare
|
Collaborator
|
Hm, this means our non-superbuild gets more and more complicated. You now need to build libevents, and mavlink manually, right? |
Collaborator
Author
|
Yes, but that's the cost of dependencies... there is no way around that, right? |
Collaborator
|
I suppose so. We should add the manual non superbuild build back to CI. |
Collaborator
Author
|
Should we merge this or do you think it breaks something? IMO the current version is wrong. |
Collaborator
|
Sorry, missed it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was skimming through the dependencies, and this seems wrong.
Why would libevent be built outside the superbuild? 🤔