Fix updating mission item total#2667
Conversation
|
Just as a clarification, function |
|
Thanks! Would you mind fixing the style with |
12b6bbf to
68ffa73
Compare
|
Pushed forced after reformatting the code. I only formatted my changes though, clang-format also reformatted unrelated file: ./ |
JonasVautherin
left a comment
There was a problem hiding this comment.
Sounds reasonable to me, but I'll let @julianoes review 😇
| auto converted_result = convert_result(result); | ||
| auto converted_items = convert_items(int_items); | ||
|
|
||
| { |
There was a problem hiding this comment.
| { | |
| if (converted_result == MissionRaw::Result::Success) { |
There was a problem hiding this comment.
Thanks for suggestion, added to the original commit.
| auto converted_result = convert_result(result); | ||
| auto converted_items = convert_items(items); | ||
|
|
||
| { |
There was a problem hiding this comment.
| { | |
| if (converted_result == MissionRaw::Result::Success) { |
Total number of items in a mission should only be updated when mission is downloaded. Downloading geofence or rally points should not affect this total.
68ffa73 to
40b02a7
Compare
|
|
Thanks @irajkovic. |
Total number of items in a mission should only be updated when mission is downloaded. Downloading geofence or rally points should not affect this total.