Skip to content

Fix: Only set the current item if index is validated#2664

Merged
julianoes merged 1 commit intomavlink:mainfrom
irajkovic:fix-set_current_mission_item_async-index-check
Sep 29, 2025
Merged

Fix: Only set the current item if index is validated#2664
julianoes merged 1 commit intomavlink:mainfrom
irajkovic:fix-set_current_mission_item_async-index-check

Conversation

@irajkovic
Copy link
Copy Markdown
Contributor

Fix for #2663.

Makes sure set_current_mission_item_async returns early to avoid calling callback a second time.

@sonarqubecloud
Copy link
Copy Markdown

Copy link
Copy Markdown
Collaborator

@JonasVautherin JonasVautherin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link
Copy Markdown
Collaborator

@julianoes julianoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooh, yes. Thanks!

@julianoes julianoes merged commit 9c2cb56 into mavlink:main Sep 29, 2025
52 of 53 checks passed
@irajkovic
Copy link
Copy Markdown
Contributor Author

Thank you for merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants