Conversation
Collaborator
Author
|
I have to review this with fresh eyes tomorrow. I might still switch to using jsoncpp instead of this manual JSON encoding and decoding madness. |
Collaborator
|
Yeah it feels like jsoncpp would make sense here 👍 |
Collaborator
Author
|
The problem I initially had using jsoncpp was that it doesn't let you order the fields and so the JSON output failed the test. I didn't want to have to use jsoncpp in the test as well (although maybe that would be fine?) and so Claude just came up with this manual generation. |
JSON doesn't support NaN, so we need to use null instead. Also, we need to assume arrays have all the same types, and not check the type of each array field. This way we can correctly use 0 for int and null for float/double.
bc2b15b to
d834038
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JSON doesn't support NaN, so we need to use null instead.
Also, we need to assume arrays have all the same types, and not check the type of each array field. This way we can correctly use 0 for int and null for float/double.