cmake: only link stdc++fs for GCC < 9#2640
Merged
julianoes merged 1 commit intomavlink:mainfrom Aug 14, 2025
Merged
Conversation
Newer GCC versions (>= 9) include the C++17 filesystem library in libstdc++ by default, so linking stdc++fs explicitly is unnecessary and may cause build errors. Update the CMake condition to link stdc++fs only when using GCC < 9, while keeping the existing exclusions for Apple, Android, and MSVC.
|
julianoes
approved these changes
Aug 13, 2025
Collaborator
julianoes
left a comment
There was a problem hiding this comment.
Thanks. I wonder if we actually support GCC < 9 at this point.
Contributor
Fyi on the Jetson Nano we have gcc 8 when using via the repo. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Newer GCC versions (>= 9) include the C++17 filesystem library in libstdc++ by default, so linking stdc++fs explicitly is unnecessary and may cause build errors.
Update the CMake condition to link stdc++fs only when using GCC < 9, while keeping the existing exclusions for Apple, Android, and MSVC.