db: correctly quote index columns to allow sqlite support
#74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yes, postgres is probably required for larger installations but I've been successfully using the bridge for months with this patch applied, so I figured I should send it upstream. As far as I know it shouldn't hurt anything on other SQL engines, but I'm far from an expert.
sumnerevans
previously requested changes
Jun 17, 2022
This is evidently more standard, and ` is a thing sqlite supports to be more compatible with MySQL.
tulir
approved these changes
Aug 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yes, postgres is probably required for larger installations but I've
been successfully using the bridge for months with this patch applied,
so I figured I should send it upstream. As far as I know it shouldn't
hurt anything on other SQL engines, but I'm far from an expert.