Store hashes of avatar photos to avoid spurious updates #66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Examples of 'old' and 'new' photo URLs for one room participant: They are so different that it would not be possible to know that they point to the same image. |
Author
|
FYI: We have this deployed in production now, with ~60 users in at least 700 bridged chats (and more than 15,000 'puppets' from the Google chat side), and it is working very well. We haven't seen any 'spurious' avatar-change events at all since it was deployed and the database was populated with hashes. |
When the bridge is restarted, Google Chat sends different URLs for the avatar images for every participant in every room. This happens even if the images have not changed, but sending 'avatar change' events into the Matrix rooms can be costly. This patch computes a SHA256 hash of the image to see if the image has actually changed; if not, the new URL is stored but no Matrix event is sent. This includes a database schema upgrade to v4.
tulir
approved these changes
Mar 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the bridge is restarted, Google Chat sends different
URLs for the avatar images for every participant in every room.
This happens even if the images have not changed, but sending
'avatar change' events into the Matrix rooms can be costly.
This patch computes a SHA256 hash of the image to see if the
image has actually changed; if not, the new URL is stored but no
Matrix event is sent.
This includes a database schema upgrade to v4.