Swift 3#74
Merged
Merged
Conversation
The README examples will need more work
| XCTAssertEqual(path.substring(from: path.index(after: path.startIndex)), name, "The url path should be \"\(name)\"") | ||
|
|
||
| let urlComponents = NSURLComponents(URL:url, resolvingAgainstBaseURL:false) | ||
| let urlComponents = URLComponents(url: url, resolvingAgainstBaseURL: false) |
There was a problem hiding this comment.
Line Length Violation: Line should be 100 characters or less: currently 107 characters (line_length)
| ] | ||
| for (counter, expectedPassword) in expectedValues { | ||
| let generator = Generator(factor: .Counter(counter), secret: secret, algorithm: .SHA1, digits: 6) | ||
| let generator = Generator(factor: .counter(counter), secret: secret, algorithm: .SHA1, digits: 6) |
There was a problem hiding this comment.
Line Length Violation: Line should be 100 characters or less: currently 109 characters (line_length)
|
|
||
| /// Attempts to initialize a token represented by the give URL. | ||
| public init?(url: NSURL, secret: NSData? = nil) { | ||
| public init?(url: URL, secret: Data? = nil) { |
There was a problem hiding this comment.
Valid Docs Violation: Documented declarations should be valid. (valid_docs)
| guard let generator = Generator(factor: .Counter(0), secret: NSData(), algorithm: .SHA1, digits: 6), | ||
| let other_generator = Generator(factor: .Counter(1), secret: NSData(), algorithm: .SHA512, digits: 8) else { | ||
| guard let generator = Generator(factor: .counter(0), secret: Data(), algorithm: .SHA1, digits: 6), | ||
| let other_generator = Generator(factor: .counter(1), secret: Data(), algorithm: .SHA512, digits: 8) else { |
There was a problem hiding this comment.
Conditional Binding Cascade Violation: Repeated let statements in conditional binding cascade should be avoided. (conditional_binding_cascade)
Line Length Violation: Line should be 100 characters or less: currently 118 characters (line_length)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Convert the project from Swift 2.3 to Swift 3. (Xcode 8.0 beta 3)