Move the SwiftLint build phase to a separate dedicated target#206
Merged
Conversation
This allows the OneTimePassword schemes to trigger the SwiftLint run when building the framework directly, but will allow other projects embedding the framework to build it without seeing lint warnings that are unlikely to be relevant to users of the framework.
Codecov Report
@@ Coverage Diff @@
## develop #206 +/- ##
========================================
Coverage 99.34% 99.34%
========================================
Files 6 6
Lines 153 153
========================================
Hits 152 152
Misses 1 1Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lint warnings are important during development of the framework, but are usually irrelevant for users of the framework.
This change allows the OneTimePassword schemes to trigger the SwiftLint run when building the framework directly, but will allow schemes of projects embedding the framework to build it without seeing lint warnings.