Skip to content

Fix compilation with Xcode 10 beta#182

Merged
mattrubin merged 2 commits into
developfrom
xcode-10
Jun 7, 2018
Merged

Fix compilation with Xcode 10 beta#182
mattrubin merged 2 commits into
developfrom
xcode-10

Conversation

@mattrubin

Copy link
Copy Markdown
Owner

The iOS 12 SDK now provides a module map for CommonCrypto. Using #if canImport(CommonCrypto) and the module map shims allows for correct compilation with both the old and new SDKs. Since the canImport check was added in Swift 4.1, an additional #if swift(>=4.1) is needed to maintain support from Swift 4.0.

mattrubin added 2 commits June 6, 2018 20:11
The iOS 12 SDK now provides a module map for CommonCrypto. Using `#if canImport(CommonCrypto)` and the module map shims allows for correct compilation with both the old and new SDKs
@mattrubin mattrubin closed this Jun 7, 2018
@mattrubin mattrubin reopened this Jun 7, 2018
@mattrubin mattrubin merged commit a1660a6 into develop Jun 7, 2018
@mattrubin mattrubin deleted the xcode-10 branch June 7, 2018 03:29
@mattrubin mattrubin added this to the 3.1.4 milestone Sep 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant