Refactor token URL parsing#150
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #150 +/- ##
===========================================
- Coverage 94.7% 94.27% -0.44%
===========================================
Files 6 6
Lines 378 384 +6
===========================================
+ Hits 358 362 +4
- Misses 20 22 +2
Continue to review full report at Codecov.
|
houndci-bot
reviewed
Oct 10, 2017
| throw DeserializationError.missingSecret | ||
| } | ||
| guard let generator = Generator(factor: factor, secret: secret, algorithm: algorithm, digits: digits) else { | ||
| // TODO: Convert Generator's failable initializer to a throwable initializer, and rethrow its errors. |
There was a problem hiding this comment.
Todo Violation: TODOs should be avoided (Convert Generator's failable i...). (todo)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor the parsing of URL into Token, replacing the complex generic parsing helper with dedicated throwing helper methods and an overall more functional, decomposed structure. Also, improve testing of several parsing edge cases.