Skip to content

Convert Algorithm case names to lowercase, following Swift 3 conventions#123

Merged
mattrubin merged 1 commit into
developfrom
lowercase-enums
Feb 5, 2017
Merged

Convert Algorithm case names to lowercase, following Swift 3 conventions#123
mattrubin merged 1 commit into
developfrom
lowercase-enums

Conversation

@mattrubin

@mattrubin mattrubin commented Feb 5, 2017

Copy link
Copy Markdown
Owner

While not made explicitly clear in the API design guidelines, in the Foundation Swift 3 API even names with are acronyms are lower-camel-case.

https://swift.org/documentation/api-design-guidelines/#follow-case-conventions

@codecov-io

codecov-io commented Feb 5, 2017

Copy link
Copy Markdown

Codecov Report

Merging #123 into develop will not impact coverage.

@@           Coverage Diff            @@
##           develop     #123   +/-   ##
========================================
  Coverage    94.73%   94.73%           
========================================
  Files            6        6           
  Lines          380      380           
========================================
  Hits           360      360           
  Misses          20       20
Impacted Files Coverage Δ
Sources/Generator.swift 100% <ø> (ø)
Sources/Crypto.swift 100% <100%> (ø)
Sources/Token+URL.swift 98.38% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update afeb9e9...38c9ae0. Read the comment docs.

@mattrubin mattrubin merged commit 463ce81 into develop Feb 5, 2017
@mattrubin mattrubin deleted the lowercase-enums branch February 5, 2017 03:33
@mattrubin mattrubin modified the milestone: 3.0 Feb 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants