Port OneTimePassword 2.1 changes to Swift 3#111
Merged
Conversation
Clean up project configuration and build settings
Add tests for validation and parsing failures
Update the Podspec
Improve documentation comments
Simplify the nesting of do-catch blocks in the Keychain tests.
Add missing changelog entries
Owner
Author
|
Travis CI's infrastructure for iOS builds has been at capacity for almost 20 hours, so I'm merging this without waiting for the CI tests to finish. These changes have been built locally for both watchOS and iOS, and tested on iOS 8.4, 9.3, and 10.1. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge the OneTimePassword 2.1 release candidate into the Swift 3 working branch.