Fix typings resolution when using TypeScript 4.7+ with ESM#83
Merged
mattphillips merged 1 commit intomattphillips:mainfrom Nov 12, 2022
Merged
Fix typings resolution when using TypeScript 4.7+ with ESM#83mattphillips merged 1 commit intomattphillips:mainfrom
mattphillips merged 1 commit intomattphillips:mainfrom
Conversation
TypeScript in ESM mode is trying to use file index.d.mts for types but there is no such file. So we need to provide custom path to typings file. Root `types` field is ignored in ESM mode
Owner
|
Thanks @Nitive |
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TypeScript in ESM mode is trying to use file
index.d.mtsfor types but there is no such file. So we need to provide custom path to typings file. Roottypesfield is ignored in ESM modeFor reference: same issue in another package telegraf/telegraf#1629 (comment)