Remove spread operator in object diffs to increase performance#64
Merged
mattphillips merged 1 commit intomattphillips:mainfrom Jan 25, 2022
Merged
Conversation
Contributor
|
Possibly equivalent to #47? It was closed for some reason. |
Codecov Report
@@ Coverage Diff @@
## main #64 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 7 7
Lines 99 109 +10
Branches 36 36
=========================================
+ Hits 99 109 +10
Continue to review full report at Codecov.
|
39ab80f to
70aa278
Compare
70aa278 to
1d430f4
Compare
Owner
|
Thanks @SheneekaW will get this published ASAP |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
While using detailedDiff from this library, ran into an issue where large enough files would cause functions to just hang. After updating the object value assignments and removing the spread operator (...), the performance improved.
**Note did not remove the spread operator from the array function or smaller utility functions.
Relied on the following functions for timing and heap usage:
How Has This Been Tested?
While making changes, made sure test suite was still good with
npm testruns