modernise reflect.SliceHeader to unsafe.Slice#1400
Merged
Conversation
Signed-off-by: Jakob Borg <jakob@kastelo.net>
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1400 +/- ##
==========================================
+ Coverage 47.16% 51.61% +4.45%
==========================================
Files 12 13 +1
Lines 1533 1856 +323
==========================================
+ Hits 723 958 +235
- Misses 669 739 +70
- Partials 141 159 +18 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Owner
|
Thank you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid the unsafe use of reflect.StringHeader, using the same pattern already in place in
bindText, and modernise deprecated reflect.SliceHeader usage to unsafe.Slice.