avoid out of bounds write in unlock_notify_wait on 64 bit platforms#1399
Merged
Conversation
While `C.sizeof_unit` is 4, we convert to a Go uint and write it to the pointer. The Go uint is eight bytes on 64 bit platforms. Signed-off-by: Jakob Borg <jakob@kastelo.net>
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1399 +/- ##
==========================================
+ Coverage 47.16% 51.64% +4.48%
==========================================
Files 12 13 +1
Lines 1533 1855 +322
==========================================
+ Hits 723 958 +235
- Misses 669 738 +69
- Partials 141 159 +18 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Owner
|
Thank you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While
C.sizeof_unitis 4, we convert to a Go uint and write it to the pointer. The Go uint is eight bytes on 64 bit platforms. Allocate the size we intend to write.