add docker swarm mode support#176
add docker swarm mode support#176pichouk merged 2 commits intomattermost:masterfrom pdemagny:swarm-support
Conversation
Signed-off-by: Pierre DEMAGNY <pdemagny@printoclock.com>
|
Looks good to me. Though I'm never run swarm mode. So I may not be in a good position to review. |
|
@pdemagny Thanks for your help ! |
pichouk
left a comment
There was a problem hiding this comment.
LGTM, but with few suggestions.
One question : did you test this on a Docker Swarm cluster ? I have no Swarm cluster so I cannot test.
Another thing is that it could be better to add your docker-swarm.yml file under a new /contrib/swarm/ directory on the repository. Usually contribution like this are on a specific folder. Don't forget to modify path on README and volumes also.
docker-swarm.yml
Outdated
| restart_policy: | ||
| condition: on-failure | ||
| web: | ||
| image: nginx:latest |
There was a problem hiding this comment.
Why not using the mattermost/mattermost-prod-web image ?
web/docker-entry.sh
Outdated
| fi | ||
| ln -s /etc/nginx/sites-available/mattermost$ssl /etc/nginx/conf.d/mattermost.conf | ||
| if [ -e "/etc/nginx/conf.d/default.conf" ]; then rm /etc/nginx/conf.d/default.conf; fi | ||
| ln -s /etc/nginx/sites-available/mattermost${ssl} /etc/nginx/conf.d/mattermost.conf |
There was a problem hiding this comment.
Good point here, but is that necessary to add this to this PR ?
To keep a correct Git history I will prefer to remove this changes from this Pull Request and to open a new one just for this (or if you don't want, I'll do the commit by myself). I will accept directly ;)
|
Also, it seems that |
|
Thanks @pichouk, posted a note about mattermod in the Developers channel: https://pre-release.mattermost.com/core/pl/8k1wnzk6ppb6pmppuocueqt6kc |
|
@pichouk Yes ofc i did test it, i wrote it & ran it within a single node swarm with ssl enabled using letsencrypt, tested a few integrations (fabric & jenkins). |
|
I'm just going to do my best Mattermod impression here since it's not going to pick up this PR now that it's already open. Thanks for the pull request! Per the CONTRIBUTING.md file displayed when you created this pull request, we need to add you to the list of approved contributors for the Mattermost project. Please help complete the Mattermost contribution license agreement? This is a standard procedure for many open source projects. Your form should be processed within 24 hours and reviewers for your pull request will be able to proceed. Please let us know if you have any questions. We are very happy to have you join our growing community! If you're not yet a member, please consider joining our Contributors community channel to meet other contributors and discuss new opportunities with the core team. |
…out & update readme accordingly. Signed-off-by: Pierre DEMAGNY <pdemagny@printoclock.com>
|
@pichouk actually, ping ;) |
|
Using official image made my modifications to docker-entry.sh irrelevant as expected. |
|
Good for me ! Thanks a lot for this contribution ! 👍 😄 |
Signed-off-by: Pierre DEMAGNY pdemagny@printoclock.com