fix: wrap HTTP_SERVER_GET_STATUS response in IpcResult envelope#57
Merged
matt1398 merged 1 commit intomatt1398:mainfrom Feb 22, 2026
Merged
Conversation
The HTTP_SERVER_GET_STATUS handler returned a raw { running, port } object
while all other HTTP server handlers (start, stop) return { success, data }.
invokeIpcWithResult() in the preload expects the IpcResult<T> envelope and
treats a missing success field as failure, throwing 'Unknown error'.
This caused an unhandled promise rejection every time the Settings page
opened, because GeneralSection calls api.httpServer.getStatus() on mount.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
Author
|
Closing to re-submit after running full quality gates (typecheck, lint, test, build). |
Contributor
Author
|
Quality gates verified before re-opening: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Opening the Settings page threw an unhandled promise rejection every time:
Root Cause
The three HTTP server IPC handlers are inconsistent in how they return data:
HTTP_SERVER_START{ success: true, data: { running, port } }✅HTTP_SERVER_STOP{ success: true, data: { running, port } }✅HTTP_SERVER_GET_STATUS{ running, port }❌invokeIpcWithResult()in the preload layer expects every handler to return anIpcResult<T>envelope ({ success, data }). Whensuccessis absent it's falsy, so the function throws:GeneralSectioncallsapi.httpServer.getStatus()on mount, so the error fired immediately every time Settings opened.Fix
Wrap the
HTTP_SERVER_GET_STATUSreturn value in the standardIpcResultenvelope, matching the other two handlers.Files Changed
src/main/index.tsHTTP_SERVER_GET_STATUSresponse inIpcResultenvelopeTest Plan
Unknown errorin the DevTools console🤖 Generated with Claude Code