Conversation
- Updated package.json to include an afterInstall script that adjusts permissions for the chrome-sandbox on Linux. - Added new afterInstall.sh script to ensure proper ownership and permissions for the sandbox file, enhancing security and functionality.
- Introduced a new "deb" section in package.json to specify post-installation scripts for Debian packages. - Enhanced the package configuration for better support of Linux distributions.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 736408e437
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| # Fix chrome-sandbox permissions for SUID sandbox on Linux | ||
| # See: https://github.com/electron/electron/issues/17972 | ||
|
|
||
| SANDBOX_PATH="/opt/${productFilename}/chrome-sandbox" |
There was a problem hiding this comment.
Use a defined install path in afterInstall script
resources/afterInstall.sh builds SANDBOX_PATH from ${productFilename}, but that shell variable is never defined in the script and is not a standard dpkg maintainer-script environment variable, so on install it expands to /opt//chrome-sandbox. In Debian installs this makes the -f check fail and skips chown/chmod, leaving chrome-sandbox permissions unchanged and the intended Linux sandbox fix ineffective.
Useful? React with 👍 / 👎.
No description provided.