fix: collect tool results from subagent messages with absent isMeta field#23
Merged
matt1398 merged 1 commit intomatt1398:mainfrom Feb 19, 2026
Merged
Conversation
…ield User messages in subagent JSONLs lack the isMeta field, defaulting to false. An unconditional `continue` in the !isMeta branch skipped tool result collection for these messages, causing all subagent tools to show "No result received". Now we check for tool_result blocks before continuing, allowing them to fall through to the result collection logic.
Owner
|
Thanks for the detailed fix and for catching the regression from #12! Looks good to me. Merging now! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tool_resultblocks lack theisMetafield (defaults tofalse). An unconditionalcontinuein the!isMetabranch caused these messages to skip tool result collection entirelytool_resultblocks before continuing, allowing them to fall through to the result collection logicBug
Fix
Testing
npm run typecheckpassesnpm run lintpassesnpm testpassestest/renderer/utils/displayItemBuilder.test.tscovering:isMeta: false+tool_resultblocks → result collected,isOrphaned: falsesubagent_input