add test for device key signatures over federation#795
Merged
Conversation
erikjohnston
requested changes
Feb 4, 2020
| matrix_create_room( $user1 ); | ||
| })->then( sub { | ||
| ( $room_id ) = @_; | ||
| matrix_sync( $user1 ); |
Member
Author
There was a problem hiding this comment.
I don't know. Probably not. I think I just cargo-culted it from somewhere else. I'll try without and if it still works, I'll drop it.
Member
Author
There was a problem hiding this comment.
It seems to be necessary, for some strange reason. If I leave it off, then synapse will return a 500 at some later sync. 😨 The backtrace is:
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/venv/lib/python3.5/site-packages/synapse/http/server.py", line 78, in wrapped_request_handler
await h(self, request)
File "/venv/lib/python3.5/site-packages/synapse/http/server.py", line 331, in _async_render
callback_return = await callback_return
File "/venv/lib/python3.5/site-packages/synapse/rest/client/v2_alpha/sync.py", line 178, in on_GET
full_state=full_state,
File "/venv/lib/python3.5/site-packages/synapse/handlers/sync.py", line 286, in wait_for_sync_for_user
full_state,
File "/venv/lib/python3.5/site-packages/twisted/internet/defer.py", line 1418, in _inlineCallbacks
result = g.send(result)
File "/venv/lib/python3.5/site-packages/synapse/handlers/sync.py", line 323, in _wait_for_sync_for_user
from_token=since_token,
File "/venv/lib/python3.5/site-packages/synapse/notifier.py", line 352, in wait_for_events
listener = user_stream.new_listener(prev_token)
File "/venv/lib/python3.5/site-packages/synapse/notifier.py", line 137, in new_listener
if self.last_notified_token.is_after(token):
File "/venv/lib/python3.5/site-packages/synapse/types.py", line 376, in is_after
(other.room_stream_id < self.room_stream_id)
File "/venv/lib/python3.5/site-packages/synapse/types.py", line 371, in room_stream_id
return int(self.room_key[1:].split("-")[-1])
ValueError: invalid literal for int() with base 10: ''
which looks like fun.
Member
There was a problem hiding this comment.
Ah, looks like sync_until_user_in_device_list uses matrix_sync_again, which sets an empty since token
Co-Authored-By: Erik Johnston <erik@matrix.org>
erikjohnston
approved these changes
Feb 5, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
corresponds to matrix-org/synapse#6844