Merged
Conversation
richvdh
requested changes
Apr 2, 2019
| @@ -0,0 +1,31 @@ | |||
| test "Can bind 3PID via home server", | |||
Member
There was a problem hiding this comment.
probably ought to have a copyright comment.
Also: is it worth starting a new subdir?
Member
Author
There was a problem hiding this comment.
probably ought to have a copyright comment.
Almost nowhere else has copyright notices, which may or may not be problematic.
Also: is it worth starting a new subdir?
I don't think so tbh, we can always do it down the line?
Member
There was a problem hiding this comment.
Almost nowhere else has copyright notices, which may or may not be problematic.
well, they should do, and we should get into the habit of adding them on new files. Don't mind leaving it for now though
Also: is it worth starting a new subdir?
I don't think so tbh, we can always do it down the line?
k then
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.