add test for /context/ with lazy_load_members filter#468
Merged
Conversation
richvdh
reviewed
Jul 27, 2018
tests/10apidoc/00prepare.pl
Outdated
| } | ||
|
|
||
|
|
||
| # assert that the given members are in the body of a sync response |
Member
There was a problem hiding this comment.
this feels out of place here. did it need to move out of 15lazy-members.pl?
tests/10apidoc/00prepare.pl
Outdated
|
|
||
|
|
||
| # assert that the given members are present in a block of state events | ||
| sub assert_room_members_in_state { |
Member
There was a problem hiding this comment.
somehow this name makes me think we're checking the state contains at least these members. Maybe assert_state_room_members_matches ?
Member
There was a problem hiding this comment.
this also feels out of place. I'm not really keen on this file being used as a dumping ground for random assertion functions.
Maybe 10apidoc/09synced.pl is a more appropriate home?
tests/10apidoc/00prepare.pl
Outdated
| sub assert_room_members_in_state { | ||
| my ( $events, $member_ids ) = @_; | ||
|
|
||
| log_if_fail "members:", $member_ids; |
Member
There was a problem hiding this comment.
s/"members:"/"expected members:"/?
richvdh
reviewed
Jul 27, 2018
Member
richvdh
left a comment
There was a problem hiding this comment.
generally lgtm modulo pedantry about naming and where functions go
Merged
And update log line to be more specific
Member
|
\o/ |
richvdh
approved these changes
Aug 15, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tests matrix-org/synapse#3567