Allow running Synapse with the asyncioreactor enabled#1301
Merged
DMRobertson merged 1 commit intomatrix-org:developfrom Oct 14, 2022
Merged
Allow running Synapse with the asyncioreactor enabled#1301DMRobertson merged 1 commit intomatrix-org:developfrom
DMRobertson merged 1 commit intomatrix-org:developfrom
Conversation
This was referenced Oct 6, 2022
Merged
DMRobertson
reviewed
Oct 14, 2022
Contributor
DMRobertson
left a comment
There was a problem hiding this comment.
It seems a bit odd to accept an env var ASYNCIO_REACTOR, convert that to a command-line flag --asyncio-reactor and then use the flag to set a different env var SYNAPSE_ASYNC_IO_REACTOR. Does SYNAPSE_ASYNC_IO_REACTOR=1 synapse_sytest.sh pass through the environment var to the synapse processes?
Well, I took a quick look at the perl and I have no idea if the environment will pass through when we spawn the process.
sytest/lib/SyTest/Homeserver/ProcessManager.pm
Lines 98 to 103 in 4fa32d0
Contributor
|
In the interests of getting asyncio tested sooner rather than later, let's roll with this. Note that matrix-org/synapse#14092 has already landed. |
DMRobertson
approved these changes
Oct 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a flag
--asyncio-reactor, which sets theSYNAPSE_ASYNCIO_REACTORenvironment variable to1.It also adds a
ASYNCIO_REACTORenvironment variable to the Docker image to set this flag.Note that it currently also sets
SYNAPSE_ASYNCIO_REACTORto0when the flag is not set, which currently enables the asyncioreactor anyway, so this will require some changes in Synapse first: matrix-org/synapse#14092Related: matrix-org/synapse#14091