Replace Crypt::NaCl::Sodium with Crypt::Ed25519#1182
Merged
Conversation
I want to update Protocol::Matrix to drop the dependency on `Crypt::NaCl::Sodium`, so this is a first step.
This essentially applies my patch at https://rt.cpan.org/Public/Bug/Display.html?id=140079 to our vendored copy of `Protocol::Matrix`, as a first step for dropping the dep on `Crypt::NaCl::Sodium`.
This requires two classes of changes:
* `Crypt::Ed25519::eddsa_verify($msg, $pub_key, $sig)` is pretty
much a drop-in replacement for
`Crypt::NaCl::Sodium->sign->verify($sig, $msg, $pub_key)`, modulo the order
of the arguments.
* We need a shim to recreate `Crypt::NaCl::Sodium->sign->keypair`.
b25db66 to
db8946d
Compare
clokep
reviewed
Dec 28, 2021
Member
clokep
left a comment
There was a problem hiding this comment.
Looks OK overall, but I had a few questions!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First we vendor in
Protocol::Matrix. Then we patch it to useCrypt::Ed25519instead ofCrypt::NaCl::Sodium. Then we switch the rest of sytest to useCrypt::Ed25519.Hopefully fixes #1114, and generally makes sytest a whole lot easier to install.