Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

Drop Python 3.5 from Trove classifier metadata.#9782

Merged
callahad merged 2 commits intomatrix-org:developfrom
callahad:py35-trove
Apr 12, 2021
Merged

Drop Python 3.5 from Trove classifier metadata.#9782
callahad merged 2 commits intomatrix-org:developfrom
callahad:py35-trove

Conversation

@callahad
Copy link
Contributor

@callahad callahad commented Apr 9, 2021 •
edited
Loading

Signed-off-by: Dan Callahan danc@element.io

Pull Request Checklist

  • Pull request is based on the develop branch
  • Pull request includes a changelog file. The entry should:
    • Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
    • Use markdown where necessary, mostly for code blocks.
    • End with either a period (.) or an exclamation mark (!).
    • Start with a capital letter.
  • Pull request includes a sign off
  • Code style is correct (run the linters)

@callahad
Drop Python 3.5 from Trove classifier metadata.
1f03e1a 
Signed-off-by: Dan Callahan <danc@element.io>
richvdh
richvdh approved these changes Apr 9, 2021
View reviewed changes
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm otherwise. good spot, thanks!

changelog.d/9782.misc Outdated
@@ -0,0 +1 @@
Drop Python 3.5 from Trove classifier metadata.
Copy link
Member

@richvdh richvdh Apr 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd update this to match the changelog from #9766.

@callahad
Re-use the newsfragment from matrix-org#9766
ccc526f 
Signed-off-by: Dan Callahan <danc@element.io>
@callahad callahad merged commit a7044e5 into matrix-org:develop Apr 12, 2021
@callahad callahad mentioned this pull request Apr 13, 2021
Closed
4 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@richvdh richvdh richvdh approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@callahad @richvdh