This repository was archived by the owner on Apr 26, 2024. It is now read-only.
Only send catch up events if they're the latest in the room#9621
Closed
erikjohnston wants to merge 2 commits intodevelopfrom
Closed
Only send catch up events if they're the latest in the room#9621erikjohnston wants to merge 2 commits intodevelopfrom
erikjohnston wants to merge 2 commits intodevelopfrom
Conversation
Member
Author
After some talk in #synapse-dev:matrix.org, I'll give this a go |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a bit of a hack to help mitigate #9492. One of the problems there is that in a busy with lots of servers, each server will send the last event they sent, which results in the server that has come back online getting a smattering of events rather than just the latest event its missed. The flip side is that it relies on whatever server that did send the last event in the room actually sending that to the newly up server.
I'm not really sure if this is what we want to do. Other thing we could do is add more metadata to the sent event to help the remote Do The Right Thing, or simply send the current forward extremities of the room to them (though currently servers drop events they get via
/sendfrom other servers).Thoughts?