Explicitly add flake8 selections#9370
Explicitly add flake8 selections#9370ShadowJonathan wants to merge 3 commits intomatrix-org:developfrom
Conversation
|
I used |
|
I'm a bit confused by this -- I thought the goal was to enable additional checks only for flake8-bugbear? If that's not possible, then I think we'll need to ignore all the ones that don't pass yet. |
|
I outlined it here, but TL;DR: It's easier to individually add the checks to It's also simply easier to work with, and easier to observe explicitly enabled > implicitly enabled, i already created some other issues which touched on those explicitly-disabled checks, to create discussion to be able to remove them. Edit: Just read your comment again, yes, that's the goal, but this is the first PR required for that, i isolated the changes to be small to this, and the next PR will be adding flake8-bugbear and non-complaining checks, once that one's merged, i'll add the one-by-one checks and the enabling in the config. See #9366. |
|
I'm not too keen to merge this as I'm not a huge fan of disabling these checks (i.e. if we never finish a project to enable bugbear and new checks get added to flake8 then we'll be missing out). I think the approach should be to disable just the bugbear checks and start fixing those issues individually. |
Pull Request Checklist
EventStoretoEventWorkerStore.".code blocks.Signed-off-by: Jonathan de Jong <jonathan@automatia.nl>Part of #9366