Dockerfile: Make wget available.#7995
Conversation
Wget is often used for Docker health checks. It was available up until the change from Alpine to Debian, so not having is available is a bit of a regression.
|
Just for reference, the health check configuration that can be used in a Docker runs this within the container, so |
|
@schildbach out of interest, what purpose does this healthcheck serve that is not simply covered by ensuring that the container is running? I guess it would detect if synapse had somehow locked up, but is that a common problem? It feels to me like the healthcheck just adds another failure mode. |
|
It makes sure Synapse has started up and is (still) responding to requests. Ideally, the app itself would implement whatever it thinks is reasonable to check. For example, for Postgres there is the |
|
Curl was added to docker in #8147, so this is probably superfluous now. |
Wget is often used for Docker health checks. It was available up until the change from Alpine to Debian, so not having is available is a bit of a regression.
Pull Request Checklist
EventStoretoEventWorkerStore.".code blocks.