This repository was archived by the owner on Apr 26, 2024. It is now read-only.
Closed
Conversation
6ef3e04 to
90b3d1c
Compare
33f4642 to
c9226c6
Compare
This encapsulates config for a given database and is the way to get new connections.
c9226c6 to
f46e0ed
Compare
richvdh
suggested changes
Dec 10, 2019
Member
richvdh
left a comment
There was a problem hiding this comment.
I'm giving up at this point, I'm afraid.
I don't think you can claim that the commits are independently reviewable when they have interdependencies: I might as well review the whole diff at once, and it's pretty big for that.
Basically I'd love it if you could split this up.
|
|
||
|
|
||
| def prepare_database(db_conn, database_engine, config): | ||
| def prepare_database(db_conn, database_engine, config, data_stores=["main"]): |
Member
There was a problem hiding this comment.
docstring for data_stores?
(do we really need the default value?)
Member
Author
|
Well, OK. I thought the changes were independent enough where it'd be easier to review, but will try and do something |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will make it easier to a) pass a single
Databaseobject to different data stores and b) have separate database configsBased on #6469 and #6487. Commits independently reviewable.