This repository was archived by the owner on Apr 26, 2024. It is now read-only.
Split out state storage into separate data store.#6245
Closed
erikjohnston wants to merge 4 commits intodevelopfrom
Closed
Split out state storage into separate data store.#6245erikjohnston wants to merge 4 commits intodevelopfrom
erikjohnston wants to merge 4 commits intodevelopfrom
Conversation
f5c309b to
a03c7f9
Compare
richvdh
suggested changes
Oct 29, 2019
Member
richvdh
left a comment
There was a problem hiding this comment.
these multi-thousand-line diffs are a bit unreviewable. Is there any way to split them up so that code moves are separate from changes?
| """ | ||
|
|
||
| def __init__(self, hs, stores: DataStores): | ||
| self.stores = stores |
| self.main = stores.main | ||
|
|
||
| self.persistence = EventsPersistenceStore(hs, stores) | ||
| self.state = StateGroupStorage(hs, stores) |
Member
There was a problem hiding this comment.
As per #6240 (comment): the inconsistency in naming between Storage and Store is... inconsistent.
Member
Author
|
Fair, I've tried to keep the massive diffs in separate commits, but let me see if I can rejig these a bit further |
Currently we always point it to the same physical database.
a03c7f9 to
2ddefcd
Compare
Member
Author
|
Ok, I'm splitting this up some more into separate PRs. |
This was referenced Oct 30, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This also includes splitting purge storage APIs into two, one that works on events and the other on state.
Based on #6240.
Commits independently reviewable.