This repository was archived by the owner on Apr 26, 2024. It is now read-only.
Set m.require_identity_server to always be False#5968
Closed
anoadragon453 wants to merge 3 commits intoanoa/reg_emailfrom
Closed
Set m.require_identity_server to always be False#5968anoadragon453 wants to merge 3 commits intoanoa/reg_emailfrom
anoadragon453 wants to merge 3 commits intoanoa/reg_emailfrom
Conversation
This was referenced Sep 3, 2019
Member
Please can you link to the PR that made this change? |
Member
Author
|
Sorry, that would be #5876 |
Member
id_server still seems to be mandatory in user-interactive auth there? https://github.com/matrix-org/synapse/pull/5876/files#diff-09aa21e5bb05afad9baeb8141a43480fR42 etc |
Member
Author
|
Hm, looks like I missed that :| |
Member
Author
|
Kind of annoying as both the v2 identity stuff and email registration things have stake in how this works. |
Member
Author
|
Superseded by #5972 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As MSC2263 states,
m.require_identity_servermust be set tofalsewhen it does not require an identity server to be provided by the client for the purposes of email registration or password reset.We were setting this on the basis of
account_threepid_delegatebeing set or not, but it should actually just always be false asanoa/reg_emailfeature branch lets the homeserver decide what upstream identity server it should use for these tasks.