This repository was archived by the owner on Apr 26, 2024. It is now read-only.
rest/media: Don't call finish in case of error#4939
Closed
jo-so wants to merge 1 commit intomatrix-org:developfrom
Closed
rest/media: Don't call finish in case of error#4939jo-so wants to merge 1 commit intomatrix-org:developfrom
jo-so wants to merge 1 commit intomatrix-org:developfrom
Conversation
When an exception occurs during the sending of data, the request doesn't needs a finishing, otherwise twisted complains `Producer was not unregistered for b'/_matrix/media/v1/thumbnail/…'`. Fixes matrix-org#4933
Member
|
I think you're probably right, but I do wonder what will happen in the case where the synapse code errors rather than the connection, as I feel like we should probably close the connection or something in that case? @hawkowl do you have any idea? |
3 tasks
Member
|
hopefully #5009 makes this redundant. |
Author
|
#5009 doesn't contain the exclusion of the useless message »Consumer asked us to stop producing« or is this solved otherwise? - logger.warning("Failed to write to consumer: %s %s", type(e), e)
+ if str(e) != "Consumer asked us to stop producing":
+ logger.warning("Failed to write to consumer: %s %s", type(e), e) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an exception occurs during the sending of data, the request doesn't
needs a finishing, otherwise twisted complains
Producer was not unregistered for b'/_matrix/media/v1/thumbnail/…'.Fixes #4933
Pull Request Checklist
Signed-off-by: Jörg Sommer <joerg@jo-so.de>