This repository was archived by the owner on Apr 26, 2024. It is now read-only.
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #4682 +/- ##
===========================================
- Coverage 75.19% 75.14% -0.05%
===========================================
Files 340 340
Lines 34736 34767 +31
Branches 5680 5683 +3
===========================================
+ Hits 26119 26126 +7
- Misses 7014 7037 +23
- Partials 1603 1604 +1 |
Member
Author
|
The individual commits should be fairly stand alone. |
Contributor
|
Looks fine. |
hawkowl
approved these changes
Feb 20, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There turns out to be a bunch of code paths not tested by sytest, including adding threepids and accepting ToS.
We fix this by adding a replication API to run post registration actions. We run this as a separate step, rather than as part of the existing replication API, mainly to reduce the amount of refactoring that would otherwise need to happen.
c.f. #4666