This repository was archived by the owner on Apr 26, 2024. It is now read-only.
Resource tracking for background processes#3553
Merged
Conversation
This introduces a mechanism for tracking resource usage by background processes, along with an example of how it will be used. This will help address #3518, but more importantly will give us better insights into things which are happening but not being shown up by the request metrics. We *could* do this with Measure blocks, but: - I think having them pulled out as a completely separate metric class will make it easier to distinguish top-level processes from those which are nested. - I want to be able to report on in-flight background processes, and I don't think we want to do this for *all* Measure blocks.
erikjohnston
approved these changes
Jul 18, 2018
Member
erikjohnston
left a comment
There was a problem hiding this comment.
Sure, though I haven't looked deeply at the way you've interfaced with prometheus
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This introduces a mechanism for tracking resource usage by background processes, along with an example of how it will be used.
This will help address #3518, but more importantly will give us better insights into things which are happening but not being shown up by the request metrics.
We could do this with Measure blocks, but:
I think having them pulled out as a completely separate metric class will make it easier to distinguish top-level processes from those which are nested.
I want to be able to report on in-flight background processes, and I don't think we want to do this for all Measure blocks.