This repository was archived by the owner on Apr 26, 2024. It is now read-only.
Use fractions for ordering of chunks#3345
Closed
erikjohnston wants to merge 3 commits intoerikj/room_chunksfrom
Closed
Use fractions for ordering of chunks#3345erikjohnston wants to merge 3 commits intoerikj/room_chunksfrom
erikjohnston wants to merge 3 commits intoerikj/room_chunksfrom
Conversation
dec8c8d to
a9c569c
Compare
Using floats turned out to be a bad idea, as it broke subtely if the needed precision was too large. This PR replaces the implementation with one that uses fractions and stores them in the database as two integers.
a9c569c to
918a505
Compare
Closed
Contributor
|
Closed for now, full PR list at #3785 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using floats turned out to be a bad idea, as it broke subtely if the
needed precision was too large. This PR replaces the implementation with
one that uses fractions and stores them in the database as two integers.
Includes PR #3342