This repository was archived by the owner on Apr 26, 2024. It is now read-only.
Try to avoid having multiple PreviewUrlResource instances#2701
Merged
Try to avoid having multiple PreviewUrlResource instances#2701
Conversation
synapse/app/media_repository.py
Outdated
Member
There was a problem hiding this comment.
quit_with_error in _base.py is a thing
erikjohnston
approved these changes
Nov 22, 2017
This avoids the scenario where we have four different PreviewUrlResources configured on a single app, each of which have their own caches and cache clearing jobs.
... to stop us doing the cache cleanup jobs on the master.
493c9e6 to
68ca864
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
... because they each run cache cleanup jobs and have their own in-memory caches, and that's not really what we want.
(NB includes #2700)