This repository was archived by the owner on Apr 26, 2024. It is now read-only.
Fix #1677 and change unique on local_media_repository_thumbnails and …#1816
Closed
jkolo wants to merge 1 commit intomatrix-org:developfrom
Closed
Fix #1677 and change unique on local_media_repository_thumbnails and …#1816jkolo wants to merge 1 commit intomatrix-org:developfrom
jkolo wants to merge 1 commit intomatrix-org:developfrom
Conversation
…nails and remote_media_cache_thumbnails
Member
|
Can one of the admins verify this patch? |
2 similar comments
Member
|
Can one of the admins verify this patch? |
Member
|
Can one of the admins verify this patch? |
Member
|
@matrixbot ok to test |
Member
|
Why do we want to change the index? |
Contributor
Author
|
I've changed the index because under my own use case it sometimes happen that the client requested multiple thumbnails of the same size but with different scaling methods, which violated the unique constrain. |
Contributor
|
@jkolo, the consensus is that we're happy merge the fix for thumbnails scaling correctly but we need a bit more time to consider modifying the thumbnail table to get rid of the UNIQUE. Any chance you could split this into two PRs? |
Contributor
Author
|
Ok, no problem
2017-02-16 14:21 GMT+01:00 Luke Barnard <notifications@github.com>:
… @jkolo <https://github.com/jkolo>, the consensus is that we're happy
merge the fix for thumbnails scaling correctly but we need a bit more time
to consider modifying the thumbnail table to get rid of the UNIQUE. Any
chance you could split this into two PRs?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1816 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABzpWpIsCI5cza2SOraR_Ibss5soSFImks5rdE1bgaJpZM4LlFrR>
.
|
This was referenced Feb 24, 2017
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…remote_media_cache_thumbnails