This repository was archived by the owner on Apr 26, 2024. It is now read-only.
Also discard 'caches' and 'backfill' stream POSITIONS#16655
Merged
erikjohnston merged 3 commits intodevelopfrom Nov 17, 2023
Merged
Also discard 'caches' and 'backfill' stream POSITIONS#16655erikjohnston merged 3 commits intodevelopfrom
erikjohnston merged 3 commits intodevelopfrom
Conversation
Follow on from #16640
clokep
reviewed
Nov 17, 2023
Member
There was a problem hiding this comment.
Do we no longer need #16557 (is this a more general solution)?
Member
Author
There was a problem hiding this comment.
Not really, that PR reduces the amount sent, this is reducing the processing of what we receive (but its still non-zero)
Member
erikjohnston
commented
Nov 17, 2023
clokep
approved these changes
Nov 17, 2023
Member
clokep
left a comment
There was a problem hiding this comment.
It looks like this the ones that we don't apply this to are the PresenceFederationStream and TypingStream (the two direct sub-classes of Stream without the additional logic).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow on from #16640