Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

Pin the recommended poetry version in contributors' guide#16550

Merged
DMRobertson merged 2 commits intodevelopfrom
dmr/poetry-1-5
Oct 25, 2023
Merged

Pin the recommended poetry version in contributors' guide#16550
DMRobertson merged 2 commits intodevelopfrom
dmr/poetry-1-5

Conversation

@DMRobertson
Copy link
Contributor

A stopgap until we work out what to do with #16147

@clokep
Copy link
Member

clokep commented Oct 25, 2023

(I think we're just waiting for a new release of poetry-core + poetry btw.)

@DMRobertson
Copy link
Contributor Author

(I think we're just waiting for a new release of poetry-core + poetry btw.)

interesting. there's a 1.7 release out already but presumably that lacks the fix we want?

@DMRobertson DMRobertson merged commit c14a7de into develop Oct 25, 2023
@DMRobertson DMRobertson deleted the dmr/poetry-1-5 branch October 25, 2023 15:31
@clokep
Copy link
Member

clokep commented Oct 25, 2023

(I think we're just waiting for a new release of poetry-core + poetry btw.)

interesting. there's a 1.7 release out already but presumably that lacks the fix we want?

See #16147 (comment), we need python-poetry/poetry-core#633 which was after the 1.7 release.

@clokep
Copy link
Member

clokep commented Oct 25, 2023

(Maybe it would work if we required poetry-core < 1.6, but I think @erikjohnston checked that and it didn't work.)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants